Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecated functions should have a @codeCoverageIgnore flag #153

Closed
andizer opened this issue Sep 20, 2019 · 1 comment
Closed

Deprecated functions should have a @codeCoverageIgnore flag #153

andizer opened this issue Sep 20, 2019 · 1 comment
Labels
Status: duplicate

Comments

@andizer
Copy link
Contributor

andizer commented Sep 20, 2019

When a method or function is deprecated we don't want it to be present in the codecoverage, just because it's deprecated and thus not used.

We should have a sniff that checks if a @codeCoverageIgnore flag is present in the docbloc.
@jrfnl
Copy link
Collaborator

jrfnl commented Sep 20, 2019

This already exists since YoastCS 1.1.0: see #95 and PR #96

@jrfnl jrfnl closed this as completed Sep 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Status: duplicate
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@andizer @jrfnl