Skip to content
This repository has been archived by the owner on Sep 28, 2023. It is now read-only.

Promo box: consider to use the user language #15

Closed
afercia opened this issue Dec 8, 2016 · 3 comments
Closed

Promo box: consider to use the user language #15

afercia opened this issue Dec 8, 2016 · 3 comments

Comments

@afercia
Copy link
Contributor

afercia commented Dec 8, 2016 •
edited by andizer
Loading

See Yoast/wordpress-seo#6186

Set user language in Spanish
Set site language in Dutch

Result:

screen shot 2016-12-08 at 09 57 34

The module is currently using get_locale(), maybe should use get_user_locale() ? Both?

Also, maybe the strings should be refactored a bit? While it makes sense to refer to the language used in the admin, there are now two languages so maybe the messages should clarify this?

screen shot 2016-12-01 at 15 22 01
@afercia afercia added the queue label Dec 8, 2016
@afercia
Copy link
Contributor Author

afercia commented Dec 8, 2016

One additional issue is that the locale name is... in English :)

screen shot 2016-12-08 at 15 30 05

@afercia afercia mentioned this issue Dec 8, 2016
Merged
@afercia afercia assigned afercia and unassigned afercia Dec 8, 2016
@afercia afercia removed their assignment Dec 8, 2016
@afercia
Copy link
Contributor Author

afercia commented Dec 9, 2016

About the GlotPress API, see future plans here: GlotPress/GlotPress#338

@terw-dan terw-dan self-assigned this Dec 13, 2016
@terw-dan terw-dan removed their assignment Dec 13, 2016
@boblinthorst boblinthorst self-assigned this Dec 14, 2016
@boblinthorst boblinthorst removed their assignment Dec 14, 2016
@boblinthorst boblinthorst self-assigned this Dec 14, 2016
@boblinthorst boblinthorst removed their assignment Dec 14, 2016
@CarolineGeven CarolineGeven mentioned this issue Dec 28, 2016
Closed
@andizer andizer assigned andizer and afercia and unassigned andizer Jan 2, 2017
@afercia afercia removed their assignment Jan 2, 2017
@terw-dan terw-dan self-assigned this Jan 3, 2017
@terw-dan terw-dan mentioned this issue Jan 3, 2017
Open
@terw-dan
Copy link
Member

terw-dan commented Jan 3, 2017

I've created a new issue for the not translated locale name:
#17

@terw-dan terw-dan removed their assignment Jan 3, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@andizer @afercia @terw-dan @boblinthorst