Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

block-out-from support for layer-shell surfaces #566

Open
LunarEclipse363 opened this issue Jul 31, 2024 · 3 comments
Open

block-out-from support for layer-shell surfaces #566

LunarEclipse363 opened this issue Jul 31, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@LunarEclipse363
Copy link

I'm not very familiar with how this works on wayland, but I've been told that

mako is a wlr-layer-shell application which doesn't use xdg-toplevel surfaces.
xdg-toplevel surfaces (colloquially known as "a window") can have an app-id. Other types of Wayland surfaces do not have an app-id.

So if I understand correctly, it's currently impossible to exclude wlr-layer-shell applications from screen recording because they don't have windows with an app-id, so you can't apply window rules to them.

Maybe this could be solved by adding layer rules like how you can already add window rules in the config?

@LunarEclipse363 LunarEclipse363 added the bug Something isn't working label Jul 31, 2024
@YaLTeR
Copy link
Owner

YaLTeR commented Jul 31, 2024

Yeah, it is currently impossible. Maybe layer-rule would be needed, or maybe even client-rule if it's possible to reliably get the binary name of the client (might be).

@YaLTeR YaLTeR added enhancement New feature or request and removed bug Something isn't working labels Jul 31, 2024
@YaLTeR YaLTeR changed the title Cannot exclude mako from screen recording block-out-from support for layer-shell surfaces Jul 31, 2024
@elkowar
Copy link
Contributor

elkowar commented Aug 28, 2024

@YaLTeR we do have the namespace of the layershell surface, which in many cases could be enough. My current usecase would be to just block out notifications from screensharing. Mako's surfaces get the namespace notifications, so matching on that would be more than sufficient.

@YaLTeR
Copy link
Owner

YaLTeR commented Aug 28, 2024

I see, good point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants