From 832d481a226323332c4c200cc9c83e33c26dd980 Mon Sep 17 00:00:00 2001 From: Hayden Laccabue Date: Thu, 27 Jun 2024 13:46:24 -0700 Subject: [PATCH] Fixing a few Coverity issues found in a couple files in /src/runtime_src/core/pcie/driver/linux/xocl/userpf --- .../core/pcie/driver/linux/xocl/userpf/xocl_hwctx.c | 4 ++-- .../core/pcie/driver/linux/xocl/userpf/xocl_ioctl.c | 2 +- .../core/pcie/driver/linux/xocl/userpf/xocl_sysfs.c | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/runtime_src/core/pcie/driver/linux/xocl/userpf/xocl_hwctx.c b/src/runtime_src/core/pcie/driver/linux/xocl/userpf/xocl_hwctx.c index 231dee2a21e..8c3fbc49e58 100644 --- a/src/runtime_src/core/pcie/driver/linux/xocl/userpf/xocl_hwctx.c +++ b/src/runtime_src/core/pcie/driver/linux/xocl/userpf/xocl_hwctx.c @@ -115,8 +115,8 @@ xocl_cu_ctx_to_info(struct xocl_dev *xdev, struct drm_xocl_open_cu_ctx *cu_args, char kname[CU_NAME_MAX_LEN]; int i = 0; - strcpy(kname, strsep(&kname_p, ":")); - strcpy(iname, strsep(&kname_p, ":")); + strlcpy(kname, strsep(&kname_p, ":"), sizeof(kname); + strlcpy(iname, strsep(&kname_p, ":"), sizeof(iname); /* Retrieve the CU index from the given slot */ for (i = 0; i < MAX_CUS; i++) { diff --git a/src/runtime_src/core/pcie/driver/linux/xocl/userpf/xocl_ioctl.c b/src/runtime_src/core/pcie/driver/linux/xocl/userpf/xocl_ioctl.c index 99953890f32..8908fe73f17 100644 --- a/src/runtime_src/core/pcie/driver/linux/xocl/userpf/xocl_ioctl.c +++ b/src/runtime_src/core/pcie/driver/linux/xocl/userpf/xocl_ioctl.c @@ -546,7 +546,7 @@ xocl_read_axlf_helper(struct xocl_drm *drm_p, struct drm_xocl_axlf *axlf_ptr, struct axlf *axlf = NULL; struct axlf bin_obj; size_t size = 0; - uint32_t slot_id; + uint32_t slot_id = 0; int preserve_mem = 0; struct mem_topology *new_topology = NULL; struct xocl_dev *xdev = drm_p->xdev; diff --git a/src/runtime_src/core/pcie/driver/linux/xocl/userpf/xocl_sysfs.c b/src/runtime_src/core/pcie/driver/linux/xocl/userpf/xocl_sysfs.c index 26f1c3bde31..886703fa584 100644 --- a/src/runtime_src/core/pcie/driver/linux/xocl/userpf/xocl_sysfs.c +++ b/src/runtime_src/core/pcie/driver/linux/xocl/userpf/xocl_sysfs.c @@ -33,7 +33,7 @@ static ssize_t xclbinuuid_show(struct device *dev, if (!xclbin_id) continue; - cnt += sprintf(buf + cnt, "%pUb\n", xclbin_id ? xclbin_id : 0); + cnt += sprintf(buf + cnt, "%pUb\n", xclbin_id); XOCL_PUT_XCLBIN_ID(xdev, i); xclbin_id = NULL; @@ -112,7 +112,7 @@ static ssize_t kdsstat_show(struct device *dev, continue; size += sprintf(buf + size, "xclbin:\t\t\t%pUb\n", - xclbin_id ? xclbin_id : 0); + xclbin_id); XOCL_PUT_XCLBIN_ID(xdev, i); xclbin_id = NULL;