Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect Typing in mrmustard.physics.triples #416

Open
1 task done
JacobHast opened this issue Jun 18, 2024 · 1 comment
Open
1 task done

Incorrect Typing in mrmustard.physics.triples #416

JacobHast opened this issue Jun 18, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@JacobHast
Copy link
Contributor

Before posting a bug report

  • I have searched exisisting GitHub issues to make sure the issue does not already exist.

Expected behavior

The Abc triples defined in mrmustard.physics.triples uses Union for the outputs, I believe this should be Tuple instead

Actual behavior

Use Tuple

Reproduces how often

100%

System information

Mr Mustard: a differentiable bridge between phase space and Fock space.
Copyright 2021 Xanadu Quantum Technologies Inc.

Python version:            3.9.19
Platform info:             Windows-10-10.0.19045-SP0
Installation path:         
c:\Users\jacob\miniconda3\envs\mrmustard_dev\lib\site-packages\mrmustard
Mr Mustard version:        0.7.3
Numpy version:             1.26.4
Numba version:             0.59.1
Scipy version:             1.13.1
The Walrus version:        0.19.0
TensorFlow version:        2.16.1

Source code

No response

Tracebacks

No response

Additional information

No response

@JacobHast JacobHast added the bug Something isn't working label Jun 18, 2024
@ziofil
Copy link
Collaborator

ziofil commented Jun 23, 2024

haha yep! ^^'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants