Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PrefixAllGlobals: sniff should check for four-letter prefixes #2467

Open
davidperezgar opened this issue Jul 20, 2024 · 4 comments · May be fixed by #2479
Open

PrefixAllGlobals: sniff should check for four-letter prefixes #2467

davidperezgar opened this issue Jul 20, 2024 · 4 comments · May be fixed by #2479

Comments

@davidperezgar
Copy link
Member

The PrefixAllGlobals sniff show that 3 letters are the minimum to make prefixes for functions and variables, but in the Plugin Review Team, We're using a minimum of 4.

We ask developers to use these minimum letters and this is our argument:

Don't try to use two (2) or three (3) letter prefixes anymore. We host nearly 100-thousand plugins on WordPress.org alone. There are tens of thousands more outside our servers. Believe us, you’re going to run into conflicts.

So, let's update this sniff.

It solves updating the number to 4 in line of the sniff.

Related with #1733 and and the update of Developer documentation.

@jrfnl jrfnl added Component: Extra Type: Enhancement Status: Requirement not met On hold until WPCS supports a particular version of a dependency (PHP, PHP_CodeSniffer, etc.). labels Jul 20, 2024
@jrfnl
Copy link
Member

jrfnl commented Jul 20, 2024

The proposed change to the plugin handbook needs to be approved and merged before this issue becomes actionable.

Once that's happened, feel free to submit a PR.

@jrfnl
Copy link
Member

jrfnl commented Jul 20, 2024

I've left a comment with my thoughts on the proposed change in the plugin handbook ticket as the proposed change appears to be based on false logic.

@jrfnl
Copy link
Member

jrfnl commented Aug 28, 2024

Looks like the plugin handbook has been updated now, so a PR to make this change could now be pulled.

@jrfnl jrfnl removed the Status: Requirement not met On hold until WPCS supports a particular version of a dependency (PHP, PHP_CodeSniffer, etc.). label Aug 28, 2024
@davidperezgar davidperezgar linked a pull request Aug 29, 2024 that will close this issue
@davidperezgar
Copy link
Member Author

I've made the PR ready to review.

@jrfnl jrfnl added this to the 3.2.0 milestone Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants