Skip to content
This repository has been archived by the owner on Feb 4, 2021. It is now read-only.

disallow the "reviewing" in edit mode #189

Open
wikipedia-mabdul opened this issue Sep 28, 2013 · 5 comments
Open

disallow the "reviewing" in edit mode #189

wikipedia-mabdul opened this issue Sep 28, 2013 · 5 comments

Comments

@wikipedia-mabdul
Copy link
Member

if a reviewer / user changes the content of the edit box and then reviews the submission his changes are lost. We should force people to save or we should take the content of the textfield... (although I don't the second idea)

@ghost ghost assigned theopolisme Sep 28, 2013
@theopolisme
Copy link
Contributor

Doing now. Trivial.

@wikipedia-mabdul
Copy link
Member Author

of course. but needed. and I'm on my search for new tickets

theopolisme added a commit that referenced this issue Sep 28, 2013
This is necessary for my fix for #189
@Technical-13
Copy link
Contributor

I like the second idea. I think that all reviewing should be done in the edit window actually. The reason for this is because there are so many things that people can do that throw the script off or aren't immediately noticeable without the edit window open.

@theopolisme
Copy link
Contributor

REVERTED -- problems with anonymous functions, see #188

@theopolisme
Copy link
Contributor

Fixed per @Technical-13's suggestion. See commit^

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants