Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wheels produced by CI #442

Open
ataymano opened this issue Dec 20, 2021 · 4 comments
Open

Fix wheels produced by CI #442

ataymano opened this issue Dec 20, 2021 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@ataymano
Copy link
Member

Currently wheel files produced by CI is not usable.

Tested on WSL2 Ubuntu 20.04 python 3.8.10

Running https://github.com/VowpalWabbit/reinforcement_learning/blob/master/examples/python/basic_usage.py
hangs with the following outputs:

ataymano@ataymano-sb1:~/src/github/VowpalWabbit/reinforcement_learning/examples/python$ python3 basic_usage.py
event_id: 032575ce-fc7a-4837-a8bb-517012c980f8
model_id: N/A
chosen action id: 1
all action probabilities [(1, 0.5), (0, 0.5)]
event_id: c8cf584c-ec46-4639-8ca9-545a6836d3cc
model_id: N/A
chosen action id: 1
all action probabilities [(1, 0.5), (0, 0.5)]
event_id: 10223fb5-8987-4908-8378-181d657efc46
model_id: N/A
chosen action id: 1
all action probabilities [(1, 0.5), (0, 0.5)]

And there is no data on server side - probably something is wrong with cpprest.

@zwd-ms
Copy link
Collaborator

zwd-ms commented Jan 27, 2022

I can try to take a look. Instead of CI, manual build should be working.

@zwd-ms zwd-ms self-assigned this Jan 27, 2022
@zwd-ms
Copy link
Collaborator

zwd-ms commented Mar 7, 2022

Some observations:

  1. Verified that building wheel locally works on WSL2 ubuntu 20.04
  2. Using the CI-produced wheel, the program hangs due to stuck background threads never joining (observed in gdb)
  3. auditwheel tries to package dependencies from a centos docker image, including libssl, but it seems to have some binary incompatibility issues on ubuntu, causing the issue. I tried to replace some dependencies without much success.

@jackgerrits
Copy link
Member

I wonder if it is possible to not bundle libssl. We should most likely be depending on the system copy right?

@zwd-ms
Copy link
Collaborator

zwd-ms commented Mar 7, 2022

yes agreed, so they can for example enjoy security updates.

@jackgerrits jackgerrits added the bug Something isn't working label Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants