Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flatbuffer dependency resolution does not work when consumed as submodule #162

Open
jackgerrits opened this issue Jul 7, 2020 · 0 comments
Open

Flatbuffer dependency resolution does not work when consumed as submodule #162

jackgerrits opened this issue Jul 7, 2020 · 0 comments
Labels
bug Something isn't working

Comments

@jackgerrits
Copy link
Member 

set(CMAKE_MODULE_PATH ${CMAKE_MODULE_PATH} "${CMAKE_SOURCE_DIR}/cmake/Modules/")
find_package(FlatBuffers REQUIRED)

${CMAKE_SOURCE_DIR} will not work when the project is consumed as as submodule. This should probably be CMAKE_CURRENT_LIST_DIR and the statement moved to the top level file to be with the other dependencies.
@jackgerrits jackgerrits added the bug Something isn't working label Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jackgerrits