Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SMS sending freezes the execution if throttle occurs #311

Open
codewahoo opened this issue Feb 20, 2022 · 1 comment
Open

SMS sending freezes the execution if throttle occurs #311

codewahoo opened this issue Feb 20, 2022 · 1 comment
Assignees
@SecondeJK
Labels
bug request

Comments

@codewahoo
Copy link

Line 51 in src/SMS/Client.php calls PHP sleep function, which expects a timeout in seconds, whereas src/SMS/ExceptionErrorHandler.php throws a ThrottleException object with a timeout in milliseconds.
Thus, the script freezes for xxx seconds instead of milliseconds.
@SecondeJK SecondeJK self-assigned this Apr 28, 2022
@manavo
Copy link

manavo commented Apr 17, 2023 •
edited
Loading

Looking at src/SMS/ExceptionErrorHandler.php, it does seem like it's setting the timeout in seconds now. So this should be resolved?

https://github.com/Vonage/vonage-php-sdk-core/blob/main/src/SMS/ExceptionErrorHandler.php#L62

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SecondeJK SecondeJK

Labels
bug request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@manavo @codewahoo @SecondeJK