Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for calling commands from an actual Scala language installation in sclicheck #3156

Open
Gedochao opened this issue Sep 6, 2024 · 0 comments
Labels
Community help wanted Issues that idicate features that are nice-to-have but core team does not have time to work on it documentation Improvements or additions to documentation DX Dev experience internal Internal or build-related changes priority: low sclicheck Issues tied to docs tests done with `sclicheck`.

Comments

@Gedochao
Copy link
Contributor

Gedochao commented Sep 6, 2024

Describe what needs to be done and why
As per #3155:

  • the scala command in docs-tests is currently just an alias for scala-cli, rather than a 1:1 use of the scala wrapper from scala:3.5.0 installation
  • scalac and scala_legacy are currently launched through their main classes with scala-cli, rather than via an actual installation (although that's largely the same, just slower)
  • we should swap scala, scalac and scala_legacy to an actual coursier installation of the default Scala version when using sclicheck.

Is your feature request related to a past ticket or discussion?

Describe alternatives you've considered
The current workaround mimics an actual Scala 3 installation close enough for our docs to be largely testable, so we might also just leave it as it is, if we won't have the time to implement this.

@Gedochao Gedochao added documentation Improvements or additions to documentation priority: low internal Internal or build-related changes DX Dev experience sclicheck Issues tied to docs tests done with `sclicheck`. Community help wanted Issues that idicate features that are nice-to-have but core team does not have time to work on it labels Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community help wanted Issues that idicate features that are nice-to-have but core team does not have time to work on it documentation Improvements or additions to documentation DX Dev experience internal Internal or build-related changes priority: low sclicheck Issues tied to docs tests done with `sclicheck`.
Projects
None yet
Development

No branches or pull requests

1 participant