Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure to test on Windows locally #16

Open
Vindaar opened this issue Dec 26, 2020 · 1 comment
Open

Make sure to test on Windows locally #16

Vindaar opened this issue Dec 26, 2020 · 1 comment

Comments

@Vindaar
Copy link
Owner

Vindaar commented Dec 26, 2020

We're currently (#15) disabling every command that actually runs stuff in a terminal on Windows CI, since the commands error. Most likely because random unix commands simply don't exist.

But need to make sure that there isn't another bug somewhere that makes the whole library not work on Windows. If so replace tests by things that work on Windows too?
Vindaar added a commit that referenced this issue Dec 26, 2020
@Vindaar
replace travis CI by Github Actions
4c24023 
This replaces travis CI by github actions.

It disables tests on Windows if they run actual commands (to be
investigated #16).

Also docs are only built on Linux.
Vindaar added a commit that referenced this issue Dec 26, 2020
@Vindaar
replace travis CI by Github Actions
aca1821 
This replaces travis CI by github actions.

It disables tests on Windows if they run actual commands (to be
investigated #16).

Also docs are only built on Linux.
@Vindaar
Copy link
Owner Author

Vindaar commented Dec 30, 2020

This was at least partially for two different reasons:

  1. windows raises OSError if a command is not found (in startProcess)
  2. we have to supply poUsePath manually, because it's normally used by default on windows iiuc.

Still should be tested manually before this is closed.

Also:
one and pipe on windows are broken!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Vindaar