Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Dismissing screenshare request causes crash #753

Open
3 tasks done
Sqaaakoi opened this issue Jul 12, 2024 · 9 comments
Open
3 tasks done

[Bug] Dismissing screenshare request causes crash #753

Sqaaakoi opened this issue Jul 12, 2024 · 9 comments
Labels
bug Something isn't working upstream related to a dependency, for example electron wontfix This will not be worked on

Comments

@Sqaaakoi
Copy link

Discord Account

sqaaakoi

Operating System

Debian trixie

Linux Only ~ Desktop Environment

KDE 5.27.10 Wayland

Package Type

deb

What happens when the bug or crash occurs?

Window will freeze and native will throw an UnhandledPromiseRejectionWarning then segfaults

What is the expected behaviour?

Not crash and do not attempt to start screensharing

How do you recreate this bug or crash?

Join a voice channel
Click the screenshare button
Click cancel/dismiss the system screenshare picker
Crash

Debug Logs

Checking for beta autoupdate feature for deb/rpm distributions
Found package-type: deb
Checking for update
Gtk-Message: 06:18:59.855: Failed to load module "appmenu-gtk-module"
[arRPC > ipc] listening at /run/user/1000/discord-ipc-0
[arRPC > websocket] listening on 6463
[arRPC > process] started
[Vencord] Installed React Developer Tools
(node:815218) ExtensionLoadWarning: Warnings loading extension at /home/sqaaakoi/.config/vesktop/ExtensionCache/fmkadmapgofadopljbjfkapdkoienihi:
  Manifest version 2 is deprecated, and support will be removed in 2024. See https://developer.chrome.com/docs/extensions/develop/migrate/mv2-deprecation-timeline for details.

(Use `vesktop --trace-warnings ...` to show where the warning was created)
Update for version 1.5.3 is not available (latest version: 1.5.3, downgrade is disallowed).
checkForUpdatesAndNotify called, downloadPromise is null
[815218:0713/061913.582636:ERROR:screencast_portal.cc(367)] Failed to start the screen cast session.
[815218:0713/061913.582650:ERROR:base_capturer_pipewire.cc(81)] ScreenCastPortal failed: 2
Error during screenshare picker Failed to get sources.
(node:815218) UnhandledPromiseRejectionWarning: TypeError: Video was requested, but no video stream was provided
    at AsyncFunction.<anonymous> (VCDMain:87:5244)
(node:815218) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1)
Segmentation fault (core dumped)

Request Agreement

  • I have searched the existing issues and found no similar issue
  • I am using the latest Vesktop and Vencord versions
  • This issue occurs on an official release (not just the AUR or Nix packages)
@Sqaaakoi Sqaaakoi added the bug Something isn't working label Jul 12, 2024
@EddoWagt
Copy link

EddoWagt commented Jul 14, 2024

Can confirm, same happens for me on fedora, wayland using flatpak

@Curve
Copy link
Member

Curve commented Jul 14, 2024

Notably does not happen to me on KDE 6.1.2 (Arch Linux), promise rejection also occurs but no crash

@FruitBoi
Copy link

Happening for me as well on wayland KDE 6.1.2 (gentoo) in flatpak

@Vendicated
Copy link
Member

can reproduce but probably not fixable by us. we changed nothing about the code, we just upgraded chrome / electron, so it's likely a regression in those

@Vendicated Vendicated added wontfix This will not be worked on upstream related to a dependency, for example electron labels Jul 16, 2024
@Daxanius
Copy link

I'm getting the same issue but in my case it's not when dismissing the request, it's when clicking the screenshare button. It just crashes and leaves the same error message in the console.

I'm on EndeavourOS with Sway, installed it through pacman.

@Daxanius
Copy link

Daxanius commented Jul 20, 2024

It looks like screenshare does not work for me even in older versions. It pops the error UnhandledPromiseRejectionWarning: TypeError: Video was requested, but no video stream was provided but this time without crashing. So it seems in the latest version the error gets popped, the screenshare request gets dismissed automatically, which in turn causes the crash.

@kubni
Copy link

kubni commented Jul 23, 2024

Same behaviour. I had that UnhandledPromiseRejectionWarning for a while, and I can't screen share on Vesktop at all.
Recently, it started segfaulting after showing that same message.

@AvirukBasak
Copy link

Can confirm on Ubuntu 24.04, Wayland, navigator.userAgent gives Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/126.0.0.0 Safari/537.36

@Covkie
Copy link

Covkie commented Sep 15, 2024

This is a regression with electron ^31.0.0

the UnhandledPromiseRejectionWarning: TypeError: Video was requested, but no video stream was provided error is unrelated to this crash (you can trigger it by dismissing the screenshare modal within discord itself without crashing).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working upstream related to a dependency, for example electron wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

9 participants