Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add data renderer for CFString types #5586

Open
jonpalmisc opened this issue Jul 11, 2022 · 4 comments · May be fixed by Vector35/workflow_objc#50
Open

Add data renderer for CFString types #5586

jonpalmisc opened this issue Jul 11, 2022 · 4 comments · May be fixed by Vector35/workflow_objc#50

Comments

@jonpalmisc
Copy link
Contributor

Rendering CFString instances in linear view as Objective-C style strings, e.g. @"Hello, world!", would be far more useful than seeing the structure itself.

The code for this is already done, just needs to be cleaned up, checked-in, and merged.
@0cyn
Copy link
Member

0cyn commented Jan 10, 2023 •
edited
Loading

Resolved with Vector35/workflow_objc#46 / 3720bcbf6c967b06d8cdf51701dc2cf88cb0499d
Available in BinaryNinja Builds >= 3.2.3973

@0cyn 0cyn closed this as completed Jan 10, 2023
@jonpalmisc
Copy link
Contributor Author

This issue refers to rendering CFString structures in linear view (not references in HLIL, etc.). From reading the commit I don't believe this resolves this.

@jonpalmisc jonpalmisc reopened this Jan 10, 2023
@0cyn 0cyn linked a pull request Jan 10, 2023 that will close this issue
Open
@psifertex
Copy link
Member

Isn't that exactly what a datarenderer does?

https://github.com/Vector35/workflow_objc/pull/50/files

@jonpalmisc
Copy link
Contributor Author

jonpalmisc commented Jan 10, 2023 •
edited
Loading

Yes, if considering what this original issue was made for. Kat's changes (fdc174dbd2245cb8d95c7c1c2d89898168312e33) render CFStrings as string literals inside of HLIL, i.e. a "code renderer" (via an arch hook) which we don't support yet.

The pull request you linked is separate (but addresses the original issue and the reason I reopened this).

@0cyn 0cyn transferred this issue from Vector35/workflow_objc Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

CFString Data Renderer Vector35/workflow_objc
3 participants
@psifertex @jonpalmisc @0cyn