Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Weapon ID Standardisation #550

Merged
merged 9 commits into from
Sep 25, 2024
Merged

Weapon ID Standardisation #550

merged 9 commits into from
Sep 25, 2024

Conversation

Peptide90
Copy link
Collaborator

Standardised all weapons to use the N14Weapon Type Calibre Name format

VlaDOS1408
VlaDOS1408 reviewed Sep 23, 2024
View reviewed changes
Resources/Migrations/N14Migrations.yml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

50: N14WeaponHunterRevolver: N14WeaponHunterRevolver45-70Hunter

  • Wrong ID. Need N14WeaponRevolver45-70Hunter

VlaDOS1408
VlaDOS1408 suggested changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@VlaDOS1408 VlaDOS1408 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

migrations.yml & revolvers.yml
N14WeaponHunterRevolver: N14WeaponHunterRevolver45-70Hunter

  • Wrong ID. Need N14WeaponRevolver45-70Hunter

Otherwise, everything is as it should be. Good job 👍

@Peptide90 Peptide90 merged commit dfa9469 into master Sep 25, 2024
7 checks passed
@Peptide90 Peptide90 deleted the weapon_ID_standards branch September 25, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VlaDOS1408 VlaDOS1408 VlaDOS1408 requested changes

Assignees
No one assigned
Labels
Changes: YML
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Peptide90 @VlaDOS1408