Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add video recording logic #35

Closed
wants to merge 1 commit into from

Conversation

patjfin
Copy link

@patjfin patjfin commented May 29, 2024

Hey @jordancde - had a chat with Alex and this is where we got to for changes in the web SDK to allow for video recordings. Should be pretty minor.

Including this PR as an example of the following changes.

Main open question is whether or not you guys use the cloud or raw recording setting in DailyCo

Changes required in vapi/web

  1. Add conditional option for recording user video
  1. This would then be passed to the Vapi backend in the [body](

    web/api.ts

    Line 3663 in e1bb6e7

    body: data,
    ) of the request to /call/web

  2. Pass this flag to the DailyCall to join with the video source enabled

this.call = DailyIframe.createCallObject({
    audioSource: true,
    videoSource: [FLAG],
});

Changes required in vapi api

  1. Add a videoRecordingUrl to the response when a request is made to the [Get Call](https://docs.vapi.ai/api-reference/calls/get-call) endpoint

or

  1. Ensure that existing recordingUrl returns .mp4 recording from Daily.co

@nikhilro
Copy link
Contributor

nikhilro commented Jun 8, 2024

thanks, resolved in #38. will be available soon!

@nikhilro nikhilro closed this Jun 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants