Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lag opening emoji window #19

Open
bergonzzi opened this issue Mar 11, 2016 · 8 comments
Open

Lag opening emoji window #19

bergonzzi opened this issue Mar 11, 2016 · 8 comments
Labels

Comments

@bergonzzi
Copy link

Adding this issue (stonesam92/ChitChat#128) here as well so you can follow up when you have the time:

Lately I experience some noticeable lag when I'm opening the emoji button. I already tried reinstalling but without any effect. Is this something also other users experience or not?

I'm using Chitchat on El Capitan / 10.11.3.

@c-o-m-m-a-n-d-e-r
Copy link
Collaborator

Yes, but this seems to be an bug in WhatsApp ... you can try http://web.whatsapp.com/ directly ... same behavior ...

@bergonzzi
Copy link
Author

Yup indeed, it's true for Safari, although on Chrome and Firefox it seems to work pretty well.

Would it be possible or are there any disadvantages of using a Chrome container instead of Safari?

@c-o-m-m-a-n-d-e-r
Copy link
Collaborator

its not all the time lagging ...i think Apple / Whatsapp have to fix this ...
I don't think you can change the webview to chrome / firefox that easy

@VagishVela VagishVela assigned VagishVela and unassigned VagishVela Mar 20, 2016
@VagishVela
Copy link
Owner

I looked into this. The javascript that controls the opening/closing of the emoji bar is on line 6734 of the main javascript file. If you search for emojiExpanded in there you will see the relevant pieces.

The click on the emoji button actually calls the javascript code which then inserts the code to show the emoji's, so that may be why there is a lag? It isn't a simple hide/show by modifying the css.

We could override the javascript for that part and make it open/close faster.

@bergonzzi
Copy link
Author

Guys, are you also using macbook pros (retina screen) when testing this?
Just by chance I put the ChitChat window on my 2nd monitor (non-retina) and noticed that there's no lag when scrolling through the emojis. As soon as I put it back on the mbp screen, the images are reloaded (probably the @2x versions) and it starts lagging. I still wouldn't know how to solve it but it's another tip.

@c-o-m-m-a-n-d-e-r
Copy link
Collaborator

yep i use a retina mbp...

this lag is something whatsapp have to fix, cause it happens in webbrowser too!

@coreice
Copy link

coreice commented Apr 24, 2016

I'm not sure what happened but the lag seems to be over. Sometimes a little lag with opening or changing emoji-categories but it responds faster then in the last months.

@ilker55
Copy link

ilker55 commented Jul 11, 2016

I've noticed that the lag only happens on the build-in display on a MBP. On a secondary monitor it's smooth.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants