Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Socket in blocking mode - requires program restart after unexpected server shutdown #5

Open
steveroch-rs opened this issue May 19, 2020 · 1 comment

Comments

@steveroch-rs
Copy link

Due to the socket being implemented as a blocking socket other software using mcrcon module is incapable of continuing execution when the connection to the server socket is closed unexpectedly (broken pipe).

Implementing the socket in non-blocking mode would resolve this issue.
Great module nonetheless :)

@unexceptable
Copy link

Sorry, haven't played with anything Minecraft related in ages, and likely won't have a chance to fix this myself any time soon. But if you feel like opening a pull request which changes how the socket is setup/used I will happily review/test it, then release a new version to pypi. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants