Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Async support? #11

Open
StevenLu2004 opened this issue Aug 8, 2021 · 1 comment
Open

Async support? #11

StevenLu2004 opened this issue Aug 8, 2021 · 1 comment

Comments

@StevenLu2004
Copy link

Hi! Thank you so much for MCRcon. I've been using it for more than a year and I couldn't be more satisfied with it. It's just that I'm recently implementing an http server that uses asyncio and also needs an Rcon, so I just want to check with you whether there currently is a plan for async support. I'm currently implementing a class AioMCRcon for my own purpose, based on your 0.6.0 release because I forgot to update, and I'm also wondering if I can later make a PR to your repo.

@unexceptable
Copy link

I'm more than happy to review and add this to the repo. We just have to make sure that non-asyc support is untouched. So any code that can be shared we should between the two, but quite likely we need to make this as two different client classes (MCRcon and AioMCRcon).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants