Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Future-proof nix support #7

Closed
morr0ne opened this issue Sep 24, 2023 · 2 comments
Closed

Future-proof nix support #7

morr0ne opened this issue Sep 24, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@morr0ne
Copy link
Contributor

morr0ne commented Sep 24, 2023

Nix support was introduced with #6, however the current implementation is lacking as it does not pin a specific rust version and is dependent on the version currently used by nixpkgs unstable repo. It also ignores any msrv or rust-toolchain file requiring it to be manually kept in sync with the rest of the project. I am pretty sure the only user is @SingleSlice so it's not an urgent issue but it needs to be fixed nonetheless

@morr0ne morr0ne added bug Something isn't working enhancement New feature or request labels Sep 24, 2023
@morr0ne morr0ne assigned ghost Sep 24, 2023
@ghost
Copy link

ghost commented Sep 24, 2023

Wanting to specify that it is not dependant on the user environment, but just the nixpkgs repo most users follow, which will be the unstable one, giving us rustc 1.71.1, this is a devshell and not a deployment shell.

The only fix will be just pinning the nixpkgs repo

@morr0ne
Copy link
Contributor Author

morr0ne commented Sep 24, 2023

Wanting to specify that it is not dependant on the user environment, but just the nixpkgs repo most users follow, which will be the unstable one, giving us rustc 1.71.1, this is a devshell and not a deployment shell.

I update the issue to reflect that

@ghost ghost removed the bug Something isn't working label Sep 24, 2023
@ghost ghost changed the title Fix nix support Future-proof nix support Sep 24, 2023
@morr0ne morr0ne closed this as not planned Won't fix, can't repro, duplicate, stale Aug 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant