Task/cdd 2169 new landing page cms #1781
Conversation
phill-stanley
force-pushed
the
task/cdd-2169-new-landing-page-cms
branch
3 times, most recently
from
5f14c34
to
cd63baa
Compare
phill-stanley
changed the title
phill-stanley
force-pushed
the
task/cdd-2169-new-landing-page-cms
branch
from
cd63baa
to
49bab1f
Compare
|
| @@ -0,0 +1,6 @@ | |||
| from django.apps import AppConfig | |||
There was a problem hiding this comment.
What was your reasoning behind making an entirely new wagtail app for this?
What stopped you from just making a new LandingPage model within the home app? That way it would be referred to as home.LandingPage instead of landing_page.LandingPage.
In my mind, the app name describes the logical grouping
|
|
||
| content_panels = Page.content_panels + [FieldPanel("sub_title"), FieldPanel("body")] | ||
|
|
||
| api_fields = [ |
There was a problem hiding this comment.
If you add the list from the base page, you don't need to repeat the seo fields here:
api_fields = UKHSAPage.api_fields + [
APIField("title"),
APIField("sub_title"),
APIField("body")
]
| 3) The path of the current page. | ||
| This always returns an empty string | ||
| e.g. `""` | ||
| This is because the homepage is assumed |
There was a problem hiding this comment.
| This is because the homepage is assumed | |
| This is because the landing page is assumed |
| @@ -4,6 +4,7 @@ | |||
| create_composite_page, | |||
| create_bulk_downloads_page, | |||
| create_landing_dashboard_page, | |||
There was a problem hiding this comment.
Might be worth renaming this old handler ot be create_home_page, so its a bit clearer.
That's my bad, I saw my name against the git blame for that. Which in my defence was way before we embarked on the actual landing page re-work 😄
Then also rename your new one to just be create_landing_page or something like that
| "type": "section", | ||
| "value": { | ||
| "heading": "Respiratory viruses", | ||
| "page_link": None, |
There was a problem hiding this comment.
Presumably we're gonna have to come back and slide the links in for the topic index pages here?
And can the frontend handle when we don't send a link
You'll need to make differnent help text for this? We restricted to 2 cards in the old home page, but we'll have a column limit this time around? |
Description
This PR includes CMS updates for the new
LandingPageFixes #CDD-2169
Type of change
Please select the options that are relevant.
Checklist: