Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getMCShowerType fails on Sh_228 #1648

Open
mdhank opened this issue Jun 28, 2023 · 1 comment
Open

getMCShowerType fails on Sh_228 #1648

mdhank opened this issue Jun 28, 2023 · 1 comment

Comments

@mdhank
Copy link
Contributor

mdhank commented Jun 28, 2023

The getMCShowerType function (https://github.com/UCATLAS/xAODAnaHelpers/blob/main/Root/HelperFunctions.cxx#L520) doesn't cover all samples. In particular, the sample mc20_13TeV:mc20_13TeV.700000.Sh_228_ttW.deriv.DAOD_PHYS.e7793_s3681_r13167_p5631
(corresponding to Sherpa 2.2.8p3) returns an Unknown. This cases processing to fail in https://github.com/UCATLAS/xAODAnaHelpers/blob/main/Root/BJetEfficiencyCorrector.cxx#L245 .

Should Sherpa 2.2.8p3 return case HelperFunctions::Sherpa22? If so, I can make an MR for this.
@mdhank
Copy link
Contributor Author

mdhank commented Apr 11, 2024

It turns out this is not supported by FTAG, but our calibrations lists are out of date: https://ftag.docs.cern.ch/algorithms/activities/mcmc/#list-of-supported-generators-with-reference-dsid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mdhank