Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

actualMu files for prw autoconfig? #1284

Open
mswiatlo opened this issue Nov 27, 2018 · 3 comments
Open

actualMu files for prw autoconfig? #1284

mswiatlo opened this issue Nov 27, 2018 · 3 comments

Comments

@mswiatlo
Copy link
Contributor

Hi,

Do we have any facility for prw autoconfig to properly add the relevant actualMu file? I see two options:

  1. Pass in the actualMu files like the GRL/lumiCalc and just always add them. I'm not sure if this breaks MC16a but since the files just contain histograms like pileup_data_run_339205 presumably this won't break MC16a.
  2. Do something like SUSYTools (https://gitlab.cern.ch/atlas/athena/blob/21.2/PhysicsAnalysis/SUSYPhys/SUSYTools/Root/SUSYObjDef_xAOD.cxx#L889) to add a configured actualMu upon detecting the right campaign.

Thoughts?

Best,
Max

@kratsg
Copy link
Contributor

kratsg commented Dec 4, 2018

/cc @kkrizka ? I think the way he wrote it, cleverly, will just look at the "year" in the path to the file you're using in the config and filter things out for anything that's not appropriate to the year you're running on. So if you just pass them all in, it should filter things out... I think.

My guess is, that because the actualMu are passed in as the PRW Config File and not the lumicalc file -- that this isn't being done correctly (which is kinda annoying b/c of PURW itself).

@kkrizka
Copy link
Contributor

kkrizka commented Dec 4, 2018

Hi all,

Looking at the file names of the actualMu config files, it does not seem like we can infer the year (and hence the campaign) from it. (ei: physics_25ns_Triggerno17e33prim.actualMu.OflLumi-13TeV-001.root) .

I would propose we copy SUSYTools further and add m_prwActualMu201XFile options for all years. Then use the determined mcCampaign value to add the right one. I'll submit an MR shortly.

Regarding @mswiatlo's point 1, I don't think it will work. The PRW tool does not check the campaign of the MC being reweighted. So if we always add them, the PRW tool will try to reweight mc16a to the 2017 actual mu data profile.

--
Karol Krizka

@mswiatlo
Copy link
Contributor Author

mswiatlo commented Dec 6, 2018

Thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants