Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Line numbers in stack traces are wrong in Node v20 #2053

Open
gthb opened this issue Sep 5, 2023 · 8 comments
Open

Line numbers in stack traces are wrong in Node v20 #2053

gthb opened this issue Sep 5, 2023 · 8 comments

Comments

@gthb
Copy link

gthb commented Sep 5, 2023

Search Terms

line numbers

Note that there is #1495, closed almost two years ago, long before Node v20 came out. I opened a new issue because (a) root causes are likely different even if the manifestation is similar, and (b) the way to reproduce is likely different as well, and (c) I can't reopen that old one anyway :) but the problem is clearly present today.

Expected Behavior

I expect line numbers in stack traces thrown from TypeScript code to match the actual line numbers in the file, when running under Node v20, as they do when running under Node v18 and v19.

Actual Behavior

When running under Node v20, line numbers in stack traces are wrong, appearing to be from the transpiled version of the module.

Steps to reproduce the problem

Run a TypeScript module in which an error is thrown. Observe that the line numbers in the stack trace of that error are incorrect when running in Node v20, but are correct when running in Node v18 or v19.

Minimal reproduction

TypeStrong/ts-node-repros#34

Specifications

  • ts-node version: v10.9.1
  • node version: v20.5.1
  • TypeScript version: v5.2.2
  • tsconfig.json, if you're using one:
{}
  • package.json:
{
  "type": "module",
  "dependencies": {
    "ts-node": "latest",
    "typescript": "latest"
  }
}
  • Operating system and version: macOS 13.5.1 (22G90)
@SoftwareAndOutsourcing
Copy link

I can reproduce this issue.

With the same code, stack trace line numbers are wrong with Node.Js 20. By just switching to Node.js 18, I get the correct ones.

@uriva
Copy link

uriva commented Nov 28, 2023

same on node 21

@gthb
Copy link
Author

gthb commented Dec 12, 2023

This problem occurs in Node v18.19.0. It does not occur in Node v18.18.2.

So, seems likely that the cause is one of the changes reported as backported from v20 in https://github.com/nodejs/node/blob/main/doc/changelogs/CHANGELOG_V18.md#2023-11-29-version-18190-hydrogen-lts-targos

As a superficial guess, my money is on feat(esm): leverage loaders when resolving subsequent loaders #43772 as a likely cause. :)

@gthb
Copy link
Author

gthb commented Dec 12, 2023

Updated TypeStrong/ts-node-repros#34 accordingly, so it now uses v18.19.0 and exhibits the problem.

@SoftwareAndOutsourcing
Copy link

I replaced ts-node with tsx, and now I get the correct line numbers with node 20.

@sparecycles
Copy link

seeing the same issue with ts-morph: a workaround seems to be adding inline source maps and running node with --enable-source-maps.

{
      ...
      sourceMap: true,
      inlineSourceMap: true,
      mapRoot: 'file:///'
}

and

project.createSourceFile(/* full '/...' */ sourcepath, source)

@apazzolini
Copy link

seeing the same issue with ts-morph: a workaround seems to be adding inline source maps and running node with --enable-source-maps.

I can confirm adding --enable-source-maps fixes this issue for me in Node 20. I did not have to enable inline source maps or change my ts-node configuration in any other way.

@dandv
Copy link

dandv commented Jun 19, 2024

node --loader=ts-node/esm --enable-source-maps myscript.ts fixes this issue for me in Node 18.19.0 as well. I didn't have to change anything in tsconfig.json.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants