Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autocomplete parentheses, arrow functions #1574

Open
cedrikaagaard opened this issue Feb 28, 2021 · 1 comment
Open

Autocomplete parentheses, arrow functions #1574

cedrikaagaard opened this issue Feb 28, 2021 · 1 comment

Comments

@cedrikaagaard
Copy link

The "Autocomplete parentheses" option doesn't work for arrow functions and this would be a nice feature to have.

@lierdakil
Copy link
Collaborator

It would be, but I don't know how to fix this. TSServer reports bound array functions as const, which they are. And parsing the info it returns about type is probably not very robust. Here's an example:

{
  "name": "test",
  "kindModifiers": "",
  "kind": "const",
  "displayParts": [
    {
      "text": "const",
      "kind": "keyword"
    },
    {
      "text": " ",
      "kind": "space"
    },
    {
      "text": "test",
      "kind": "localName"
    },
    {
      "text": ":",
      "kind": "punctuation"
    },
    {
      "text": " ",
      "kind": "space"
    },
    {
      "text": "(",
      "kind": "punctuation"
    },
    {
      "text": ")",
      "kind": "punctuation"
    },
    {
      "text": " ",
      "kind": "space"
    },
    {
      "text": "=>",
      "kind": "punctuation"
    },
    {
      "text": " ",
      "kind": "space"
    },
    {
      "text": "void",
      "kind": "keyword"
    }
  ],
  "documentation": []
}

That's pretty much all we can coax out of tsserver. I don't know how to decide whether we need to add parentheses or not based off this. If anyone has suggestions -- feel free to chime in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants