Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger benchmarking with Bors commands #1341

Closed
yebai opened this issue Jun 29, 2020 · 2 comments
Closed

Trigger benchmarking with Bors commands #1341

yebai opened this issue Jun 29, 2020 · 2 comments

Comments

@yebai
Copy link
Member

yebai commented Jun 29, 2020

Turing's benchmarking is not used often at the moment. I think part of the reason is that the benchmarking process is a bit complicated, even with Nanosoldiers. Would it make sense to try to

  • trigger benchmarking for PRs using bors bot, with a customised command (see below)
  • replace Nanosoldier with PkgBenchmark , which is designed specifically for track performance changes of Julia packages.

Ps: some references:

  • bors try arguments: these arguments are stored as commit message, and can be extracted by the benchmarking script.
  • perhaps: bors try --benchmarking?
@devmotion
Copy link
Member

Maybe https://github.com/tkf/BenchmarkCI.jl could be useful. The trigger of the Github action could be adjusted to whatever we think would be suitable.

@yebai yebai closed this as completed Dec 16, 2021
@yebai yebai reopened this Dec 16, 2021
@yebai
Copy link
Member Author

yebai commented Dec 16, 2021

Closed in favour of TuringLang/DynamicPPL.jl#346

@yebai yebai closed this as completed Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants