Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewriting advancedvi docs #53

Merged
merged 39 commits into from
Jun 3, 2024

Conversation

Red-Portal
Copy link
Member

Documentations for the 0.3.0 rewrite.

Copy link

codecov bot commented Jan 9, 2024

Codecov Report

Attention: Patch coverage is 45.00000% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 81.81%. Comparing base (9ebfc3f) to head (75f2cd3).
Report is 3 commits behind head on master.

Current head 75f2cd3 differs from pull request most recent head c157787

Please upload reports for the commit c157787 to get more accurate results.

Files Patch % Lines
ext/AdvancedVIBijectorsExt.jl 50.00% 9 Missing ⚠️
src/utils.jl 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #53      +/-   ##
==========================================
- Coverage   85.92%   81.81%   -4.12%     
==========================================
  Files          11       11              
  Lines         199      209      +10     
==========================================
  Hits          171      171              
- Misses         28       38      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coveralls
Copy link

coveralls commented May 27, 2024

Pull Request Test Coverage Report for Build 9328347532

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 86.364%

Totals Coverage Status
Change from base Build 7396968164: 0.0%
Covered Lines: 171
Relevant Lines: 198

💛 - Coveralls

Copy link
Member

@yebai yebai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Red-Portal -- I added some minor comments below. Overall, it looks very good.

README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
docs/src/elbo/repgradelbo.md Outdated Show resolved Hide resolved
docs/src/elbo/repgradelbo.md Outdated Show resolved Hide resolved
docs/src/elbo/repgradelbo.md Show resolved Hide resolved
docs/src/elbo/repgradelbo.md Outdated Show resolved Hide resolved
src/utils.jl Outdated
@@ -32,3 +32,7 @@ function catsamples_and_acc(
return (x, ∑y)
end

function samples_expand_dim(x::AbstractVector)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest we inline this function and add a comment, instead of creating an additional utility that can be used only once.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking of using this as an abstraction for the future, where we get to use NamedTuple-variate random variables. It would also make it easier to track where we explicitly assume which axes are what, which I think could be useful for maintenance.

@Red-Portal
Copy link
Member Author

@yebai Thanks for your review! I tried to address most things, I think we are finally good to go?

@yebai yebai merged commit efbc9c5 into TuringLang:master Jun 3, 2024
6 checks passed
@yebai
Copy link
Member

yebai commented Jun 3, 2024

Thanks @Red-Portal!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants