fix bug in reparameterization with Bijectors.TransformedDistribution
#52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #52 +/- ##
==========================================
+ Coverage 85.92% 86.36% +0.43%
==========================================
Files 11 11
Lines 199 198 -1
==========================================
Hits 171 171
+ Misses 28 27 -1 ☔ View full report in Codecov by Sentry. |
yebai
requested changes
Dec 23, 2023
There was a problem hiding this comment.
Thanks @Red-Portal -- it looks good. I left a few minor comments below.
yebai
approved these changes
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
Bijectors.TransformedDistributionresults in an error when used with a single Monte Carlo sample. This patch fixes this and adds tests to detect this bug.