Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Random.default_rng #43

Merged
merged 1 commit into from
Feb 20, 2023
Merged

Use Random.default_rng #43

merged 1 commit into from
Feb 20, 2023

Conversation

devmotion
Copy link
Member

Random.GLOBAL_RNG just exists for backwards compatibility but one should use default_rng nowadays.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 4227367341

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 62.319%

Totals Coverage Status
Change from base Build 4088196069: 0.0%
Covered Lines: 86
Relevant Lines: 138

💛 - Coveralls

@codecov
Copy link

codecov bot commented Feb 20, 2023

Codecov Report

Base: 62.31% // Head: 62.31% // No change to project coverage 👍

Coverage data is based on head (01dada8) compared to base (64ef0ee).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #43   +/-   ##
=======================================
  Coverage   62.31%   62.31%           
=======================================
  Files           8        8           
  Lines         138      138           
=======================================
  Hits           86       86           
  Misses         52       52           
Impacted Files Coverage Δ
src/AdvancedVI.jl 72.91% <ø> (ø)
src/advi.jl 80.00% <ø> (ø)
src/utils.jl 42.85% <ø> (ø)
src/objectives.jl 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@devmotion devmotion merged commit c2c4d8b into master Feb 20, 2023
@delete-merged-branch delete-merged-branch bot deleted the dw/default_rng branch February 20, 2023 22:23
@coveralls
Copy link

coveralls commented Sep 14, 2024

Pull Request Test Coverage Report for Build 4227367341

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-13.5%) to 48.81%

Totals Coverage Status
Change from base Build 4088196069: -13.5%
Covered Lines: 41
Relevant Lines: 84

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants