Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional validation to user inputs #125

Open
MatijaNovosel opened this issue Oct 10, 2022 · 3 comments
Open

Add additional validation to user inputs #125

MatijaNovosel opened this issue Oct 10, 2022 · 3 comments
Assignees

Comments

@MatijaNovosel
Copy link

Is your feature request related to a problem? Please describe.
When the user is adding a new shape, there is no limit on how many characters the user can enter in the description or name fields which can lead to unsanitized and large inputs that can congest the database.

Describe the solution you'd like
The solution proposed is adding a max character count to the user input, both on the backend and frontend since it is not secured on either side.

@FuryACE007
Copy link

Hi @MatijaNovosel , I would like to work on this issue. Could you please guide me how to go ahead ?

@MatijaNovosel
Copy link
Author

MatijaNovosel commented Oct 17, 2022

Hi @MatijaNovosel , I would like to work on this issue. Could you please guide me how to go ahead ?

Hi! Are you asking me to assign the issue to you or are you asking me how to solve it? If it's the former, I'd kindly ask @atapas to assign you since I don't have a lot of spare time.

If it's the latter, for the backend I'd suggest looking here for the method that creates the shape and here for the frontend.

I suggest looking at this since the project uses react-bootstrap and Formik is easy to use.

@shivam969619
Copy link

can i take this issue??

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants