Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: send/receive opus/vpx encoded A/V frames from toxav instead of decoded frames #919

Open
envsh opened this issue Jun 19, 2018 · 5 comments
Labels
enhancement New feature for the user, not a new feature for build script P3 Low priority toxav Audio/video
Milestone

Comments

@envsh
Copy link

envsh commented Jun 19, 2018

I am working on tox-homeserver, need forward all messages, AV streams.
Now toxcore default decode/encode stream already, API only get raw stream, like PCM or YUV.
If forward PCM or YUV is not boundwidth efficient, waste CPU and bandwidth.I want get network stream of OPUS or vp8 and forward this.
So is some optional switch can do that?

@tox-user tox-user added the question Questions label Jun 20, 2018
@sudden6
Copy link

sudden6 commented Jun 21, 2018

No, there's no such thing. You would have to patch toxcore to do this.

@envsh
Copy link
Author

envsh commented Jun 21, 2018

can toxcore add an option for this?

@iphydf iphydf added enhancement New feature for the user, not a new feature for build script P3 Low priority toxav Audio/video and removed question Questions labels Jun 21, 2018
@iphydf iphydf changed the title Optional disable AV decoding/encoding in toxcore scope Feature request: send/receive opus/vpx encoded A/V frames from toxav instead of decoded frames Jun 21, 2018
@iphydf
Copy link
Member

iphydf commented Jun 21, 2018

We can do that. It's low priority for us at the moment, but PRs are welcome. This can be done without breaking APIs, but it'll need a bit of thought on how to design the new API. If you have a proposal for the API, please send that for review.

@iphydf iphydf added this to the v0.2.x milestone Jul 16, 2018
@zoff99
Copy link

zoff99 commented Feb 20, 2022

@envsh there is support for that in the experimental fork of toxcore at:

https://github.com/zoff99/c-toxcore/blob/ac915862974b93aa4cff203fe417a0cb69af23ab/toxav/toxav.h#L739

bool toxav_video_send_frame_h264(ToxAV *av, uint32_t friend_number, uint16_t width, uint16_t height, const uint8_t *buf,
                                 uint32_t data_len, TOXAV_ERR_SEND_FRAME *error);

https://github.com/zoff99/c-toxcore/blob/ac915862974b93aa4cff203fe417a0cb69af23ab/toxav/toxav.h#L853

void toxav_callback_video_receive_frame_h264(ToxAV *av, toxav_video_receive_frame_h264_cb *callback, void *user_data);

@zoff99
Copy link

zoff99 commented Dec 20, 2023

also when this is merged #1431 you will be able to do this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature for the user, not a new feature for build script P3 Low priority toxav Audio/video
Projects
None yet
Development

No branches or pull requests

5 participants