Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Processing doesn't start for combs that require bottles if you add the bottles after the combs #348

Open
1 task done
mouseas opened this issue Jul 15, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@mouseas
Copy link

mouseas commented Jul 15, 2022

Bug Description

When using a powered single-block centrifuge, if you have combs that require a bottle to process, and the empty bottle slot is empty when you insert the combs, then later insert empty bottles, the centrifuge will not start processing. If the bottles are inserted first, followed by the combs, processing starts as expected.

I haven't tested it with either of the multiblock centrifuges, but those should definitely be tested as well.

How to Reproduce?

  1. Place and power a single block powered centrifuge.
  2. Insert a comb which requires empty bottles in order to process it.
  3. Insert empty bottles. Processing will not start.
  4. Remove the comb and place it back in the input slot. Processing will start.

Expected Behavior

Processing should start if all the requirements are met, regardless of the order items are inserted.

Version

ResourcefulBees-1.16.5-0.10.6.jar

Mod Loader Version

Forge 36.2.35, MC 1.16.5

Logs or additional context

Modpack is Sky Bees 2 via Curseforge

Acknowledgement

  • I agree that I read the terms at the top of the page.
@mouseas mouseas added the bug Something isn't working label Jul 15, 2022
@Epic428
Copy link
Member

Epic428 commented Jul 15, 2022

Iirc the reason for this is because there’s two versions of the recipe. One with bottles and one without because without bottles we put honey into an internal tank. So when you put combs in without a bottle we try to get the recipe for it and then we cache that recipe. Adding bottles after the fact isn’t going to change which recipe is being done without resetting the cached recipe. Recipe lookups can get expensive if you make too many calls, so we try to cache the data where we can to reduce map lookups.

however in 1.19 this would be a non issue due to the fact that bottle stuff no longer exists.

@cmd276
Copy link

cmd276 commented Sep 6, 2022

I was going to do a report for this if it wasn't done already. But since it's mostly here, I feel confident enough I can add onto this one instead. If you wanted me to make a new report instead, let me know and I will.

My differences from original post:

Bug Description
Same as original post, But I wanted to specifically point out the Spelling Honeycomb has been doing this to me, and it only has one recipe. (None of the other Honeycombs do this to me yet, just the Spelling Honeycomb.)

Version
ResourcefulBees-1.16.5-0.10.7.jar

Mod Loader Version
Forge 36.2.34, MC 1.16.5

Logs or additional context
Modpack is Enigmatica 6 Expert

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants