Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Revise Breaking: #100229 - Convert JSConfirmation to a BitSet #1065

Open
TYPO3IncTeam opened this issue Oct 2, 2024 · 0 comments
Open
Labels

Comments

@TYPO3IncTeam
Copy link
Collaborator

ℹ️ View this commit on Github
👥 Authored by Thomas Hohn [email protected]
✔️ Merged by Garvin Hicking [email protected]

Commit message

[DOCS] Revise Breaking: #100229 - Convert JSConfirmation to a BitSet

Resolves: #105173
Related: #100229
Releases: main
Change-Id: I3e66324735f8424159074bf3d8ed5a2de282f2c6
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/86393
Reviewed-by: David Bruchmann [email protected]
Reviewed-by: Garvin Hicking [email protected]
Tested-by: Chris Müller [email protected]
Tested-by: core-ci [email protected]
Reviewed-by: Chris Müller [email protected]
Tested-by: Garvin Hicking [email protected]

➗ Modified files

13.0/Breaking-100229-ConvertJSConfirmationToBitSet.rst
@@ -11,7 +11,8 @@ See :issue:`100229`
 Description
 ===========
 
-:php:`\TYPO3\CMS\Core\Type\Bitmask\JSConfirmation` is now
+The class :php:`\TYPO3\CMS\Core\Type\Bitmask\JSConfirmation` is replaced by
+:php:`\TYPO3\CMS\Core\Authentication\JsConfirmation`. The new class is
 extending the :php:`\TYPO3\CMS\Core\Type\BitSet` class instead of
 :php:`\TYPO3\CMS\Core\TypeEnumeration\Enumeration`.
 
@@ -48,6 +49,9 @@ if first argument passed is not an :php:`int`.
 Migration
 =========
 
+Replace existing usages of :php:`\TYPO3\CMS\Core\Type\Bitmask\JSConfirmation`
+with :php:`\TYPO3\CMS\Core\Authentication\JsConfirmation`.
+
 There is no migration for the methods:
 
 - :php:`matches()`
@@ -56,7 +60,9 @@ There is no migration for the methods:
 
 Remove existing calls to static methods
 :php:`\TYPO3\CMS\Core\Type\Bitmask\JSConfirmation::method()`
-except for the method :php:`\TYPO3\CMS\Core\Type\Bitmask\JSConfirmation::compare()`
+and where :php:`JSConfirmation::compare()` is used, replace the namespace from
+:php:`\TYPO3\CMS\Core\Type\Bitmask\JSConfirmation` to
+:php:`\TYPO3\CMS\Core\Authentication\JsConfirmation`.
 
 Ensure an int value is passed to:
 
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant