Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace JsonWebKey2020 with JsonWebKey #73

Open
decentralgabe opened this issue Dec 5, 2023 · 12 comments
Open

Replace JsonWebKey2020 with JsonWebKey #73

decentralgabe opened this issue Dec 5, 2023 · 12 comments
Labels
enhancement New feature or request

Comments

@decentralgabe
Copy link
Member

JsonWebKey2020 is deprecated, as it was published as a part of a now-defunct CCG draft here. It has been replaced with the recommendation-track JsonWebKey defined in vc-jose-cose.

We should replace all instances of JsonWebKey2020 in code, test vectors, docs, etc. with JsonWebKey.
@decentralgabe decentralgabe mentioned this issue Dec 13, 2023
Open
@mistermoe
Copy link
Member

@decentralgabe what timeframe do you think makes sense for a change like this? should we prioritize it in your opinion?

@decentralgabe
Copy link
Member Author

I would wait until https://w3c.github.io/vc-jose-cose/ is in Candidate Recommendation. I will report back here when that happens. Hopefully within a month or so.

@mistermoe
Copy link
Member

@andresuribe87 andresuribe87 mentioned this issue Jan 10, 2024
Merged
@decentralgabe decentralgabe mentioned this issue Jan 16, 2024
Merged
@nitro-neal
Copy link
Contributor

image

It may turn into non trivial changeif there are significant changes to JsonWebKey2020 and the new one right?

https://w3c.github.io/vc-jose-cose/#verification-methods

At first glance it looks like there are some differences

@decentralgabe
Copy link
Member Author

@mistermoe what differences do you see? It should be a drop in replacement

@mistermoe
Copy link
Member

@decentralgabe I think the above comment was intended for @nitro-neal ?

@decentralgabe
Copy link
Member Author

Oops yup

@mistermoe
Copy link
Member

@nitro-neal ^

@nitro-neal
Copy link
Contributor

In searching for instances of JsonWebKey2020 in our codebase in kt I only found this in the didIon.kt but yea it seems like it does not conform.

  • Missing type
  • Controller is not optional
  • Remove relationship?
image

@decentralgabe
Copy link
Member Author

that all seems right @nitro-neal

@nitro-neal nitro-neal mentioned this issue Feb 6, 2024
Closed
@nitro-neal
Copy link
Contributor

web5-spec - #113
web5-kt - TBD54566975/web5-kt#220

@frankhinek frankhinek mentioned this issue Feb 15, 2024
Merged
frankhinek added a commit to TBD54566975/dwn-sdk-js that referenced this issue Feb 15, 2024
@frankhinek
Update JWK Verification Method Schema to support JsonWebKey (#689)
78620bd 
This PR will:
- Update the JWK verification method schema to support `JsonWebKey` in
addition to `JsonWebKey2020`.

### Context

- All Web5 SDKs use `JsonWebKey` when creating DHT DIDs
- `JsonWebKey` used by the [DID DHT method
specification](https://did-dht.com/#representing-keys)
- Eventually all Web5 SDKs will use `JsonWebKey` for DIDs per [this open
issue](TBD54566975/web5-spec#73).

> JsonWebKey2020 is deprecated, as it was published as a part of a
now-defunct [CCG draft
here](https://www.w3.org/community/reports/credentials/CG-FINAL-lds-jws2020-20220721/).
It has been replaced with the recommendation-track JsonWebKey defined in
[vc-jose-cose](https://w3c.github.io/vc-jose-cose/).

---------

Signed-off-by: Frank Hinek <[email protected]>
@decentralgabe decentralgabe mentioned this issue Feb 22, 2024
Merged
12 tasks
@jiyoontbd jiyoontbd linked a pull request Feb 26, 2024 that will close this issue
Updating to JsonWebKey TBD54566975/web5-kt#220
Closed
@decentralgabe decentralgabe added the enhancement New feature or request label Aug 16, 2024
@decentralgabe
Copy link
Member Author

What is the status on this today? Do we support both types everywhere? Just one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
SDK Development
Status: No status
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Updating to JsonWebKey TBD54566975/web5-kt
3 participants
@mistermoe @nitro-neal @decentralgabe