From 52a3d48813a8183c3ca38e4f61a301e565d94d4c Mon Sep 17 00:00:00 2001 From: Murphy Chen Date: Tue, 27 Jun 2023 17:11:35 +0800 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Dominik Rosiek <58699848+sumo-drosiek@users.noreply.github.com> --- helm/tailing-sidecar-operator/conf/operator.yaml | 2 +- operator/config.go | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/helm/tailing-sidecar-operator/conf/operator.yaml b/helm/tailing-sidecar-operator/conf/operator.yaml index 52fdbdc6..620d36aa 100644 --- a/helm/tailing-sidecar-operator/conf/operator.yaml +++ b/helm/tailing-sidecar-operator/conf/operator.yaml @@ -3,4 +3,4 @@ sidecar: leaderElection: leaseDuration: {{ .Values.operator.leaderElection.leaseDuration }} renewDeadline: {{ .Values.operator.leaderElection.renewDeadline }} - retryPeriod: {{ .Values.operator.leaderElection.retryPeriod }} \ No newline at end of file + retryPeriod: {{ .Values.operator.leaderElection.retryPeriod }} diff --git a/operator/config.go b/operator/config.go index 352983a1..d7684cbd 100644 --- a/operator/config.go +++ b/operator/config.go @@ -28,6 +28,7 @@ func ReadConfig(configPath string) (Config, error) { Sidecar: SidecarConfig{ Image: "sumologic/tailing-sidecar:latest", }, + // reference for values: https://github.com/open-telemetry/opentelemetry-operator/blob/a8653601cd6a6e2b35fd7f3e1a28b4e9608fb794/main.go#L181 leaderElection: leaderElectionConfig{ LeaseDuration: time.Second * 137, RenewDeadline: time.Second * 107,