Random Enchants quality settings not applied

[akanix42]

I haven't modified the default configuration, but I'm regularly getting gray items with enchantments.
When I look in mod_randomenchants.conf.dist, it is set to:

RandomEnchants.HighQuality = 4
RandomEnchants.LowQuality = 3

However, when I look at the source code:

if ((Quality < LowQuality && Quality > HighQuality) || (Class != 2 && Class != 4))

I believe the first test should be (Quality < LowQuality || Quality > HighQuality) as otherwise it will always be false as long as LowQuality <= HighQuality (and it seems unlikely to me that the alternative, where HighQuality < LowQuality, is what you intended).

[StygianTheBest]

Thanks for the report! Yes, as indicated in the source, this needed further testing to ensure it was performing as intended. If you want to test it and open a PR that would be excellent, if not, I'll test it when I get the time and push it out on the next release.

[StygianTheBest]

I'm merging many reported issues with this module.

• Random Enchants not working #61
• Random Enchants don't work in a group #56