From 1a0144e74cf0a863f4724b9b80d14c5496ef020a Mon Sep 17 00:00:00 2001 From: cbartondock Date: Tue, 30 Apr 2024 16:00:53 -0400 Subject: [PATCH] small cleanup --- src/lib/file-parser.ts | 2 +- src/renderer/services/preview.service.ts | 9 ++------- 2 files changed, 3 insertions(+), 8 deletions(-) diff --git a/src/lib/file-parser.ts b/src/lib/file-parser.ts index ebbfde4e82..0bb449ebbe 100644 --- a/src/lib/file-parser.ts +++ b/src/lib/file-parser.ts @@ -557,7 +557,7 @@ export class FileParser { resolve(parsedConfig) }) } catch(e) { - reject(`Backed up images step for blech:\n ${e}`) + reject(`Backed up images step for "${parsedConfig.configurationTitle}":\n ${e}`) } }) } diff --git a/src/renderer/services/preview.service.ts b/src/renderer/services/preview.service.ts index 91ba71b162..ee08d4d765 100644 --- a/src/renderer/services/preview.service.ts +++ b/src/renderer/services/preview.service.ts @@ -436,7 +436,6 @@ export class PreviewService { setTimeout(this.generatePreviewDataCallback.bind(this), 100); } else { - let oldPreviewData = this.previewData; this.previewData = undefined; let previewData; this.loggerService.info(this.lang.info.executingParsers, { invokeAlert: true }); @@ -466,7 +465,7 @@ export class PreviewService { } else { this.loggerService.info(this.lang.info.shutdownSteam, { invokeAlert: true, alertTimeout: 3000 }); - previewData = await this.createPreviewData(data.parsedData.parsedConfigs, oldPreviewData); + previewData = await this.createPreviewData(data.parsedData.parsedConfigs); } } else if (data.invalid.length === 0 && data.skipped.length === 0) { @@ -507,7 +506,7 @@ export class PreviewService { this.sgdbToArt = artworkCache.sgdbToArt; } - private async createPreviewData(data: ParsedUserConfiguration[], oldData?: PreviewData) { + private async createPreviewData(data: ParsedUserConfiguration[]) { let steamTreeData = steam.generateTreeFromParsedConfig(data); let treeData: {gridData: SteamTree, steamTreeData: SteamTree}; if (this.appSettings.previewSettings.retrieveCurrentSteamImages) @@ -525,14 +524,11 @@ export class PreviewService { for (let i = 0; i < data.length; i++) { let config = data[i]; - let oldDataDir = oldData !== undefined ? oldData[config.steamDirectory] : undefined; - if (previewData[config.steamDirectory] === undefined) previewData[config.steamDirectory] = {}; for (let j = 0; j < config.foundUserAccounts.length; j++) { let userAccount = config.foundUserAccounts[j]; - let oldDataAccount = oldDataDir !== undefined ? oldDataDir[userAccount.accountID] : undefined; if (previewData[config.steamDirectory][userAccount.accountID] === undefined) { previewData[config.steamDirectory][userAccount.accountID] = { @@ -554,7 +550,6 @@ export class PreviewService { } else { appID = steam.lengthenAppId(executableLocation.replace(/\"/g,"")); } - let oldDataApp = oldDataAccount !== undefined ? oldDataAccount.apps[appID] : undefined; if (shortcutsData[config.steamDirectory][userAccount.accountID][appID] !== undefined) { if (shortcutsData[config.steamDirectory][userAccount.accountID][appID]['icon'] !== undefined) {