Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: rename IDMixin to ID #1041

Open
apdavison opened this issue Mar 10, 2021 · 6 comments
Open

Suggestion: rename IDMixin to ID #1041

apdavison opened this issue Mar 10, 2021 · 6 comments
Assignees
Labels
Milestone

Comments

@apdavison
Copy link
Contributor

I noticed when debugging a script using spyNNaker that objects of type "IDMixin" appear where I would expect to see type "ID". The name "IDMixin" is not intended to be part of the PyNN API. In the PyNN "common" implementation, the class is used as a mixin for subclassing int or long, it does not have an __init__(). I think the best solution would be to rename the class in spyNNaker to ID. This is of course not urgent, it has no functional effect, just caused me some confusion when debugging.

@Christian-B
Copy link
Member

Christian-B commented Mar 11, 2021

In PyNN if you do

foo = sim.Population(10, ....
x = foo[2:3]
y = foo[1]

x would be a PopulationView

What kind of Object should y be?

Can y also be just a PopulationView too or does it need to be a different object and if so what?

@apdavison
Copy link
Contributor Author

y should be an ID object, although this name is potentially confusing, and the class could be renamed Cell or Neuron.

@Christian-B Christian-B self-assigned this Mar 11, 2021
@Christian-B Christian-B added this to the 7.0.0 milestone Mar 11, 2021
@Christian-B
Copy link
Member

"Cell" is already used for neuron model cell type and "neuron" is already over used.

I am thinking of using PopulationID which goes nicely with PopulationView

@apdavison
Copy link
Contributor Author

Using a different name from other PyNN implementations is confusing, that's why I opened this ticket. If we change, it should be done across all implementations. I've opened NeuralEnsemble/PyNN#715 to discuss this question and the relationship to PopulationView. I'd appreciate input from the SpiNNaker side there.

@Christian-B
Copy link
Member

I completely agree that Using a different name from other PyNN implementations is confusing!

I will await the decision in NeuralEnsemble/PyNN#715 and then implement the same in SpyNNaker

@Christian-B
Copy link
Member

Still awaiting the decision what to do here in NeuralEnsemble/PyNN#715

@dkfellows dkfellows modified the milestones: 7.0.0, 7.1.0 Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants