Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upg explain leads to DeprecationWarning on Windows #3

Open
cpopell opened this issue Nov 19, 2022 · 8 comments
Open

upg explain leads to DeprecationWarning on Windows #3

cpopell opened this issue Nov 19, 2022 · 8 comments

Comments

@cpopell
Copy link

cpopell commented Nov 19, 2022

ran 'upg explain', got the following error:

(node:39688) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.
(Use `node --trace-deprecation ...` to show where the warning was created)```
@ctjlewis
Copy link
Collaborator

@cpopell What's node -v?

@cpopell
Copy link
Author

cpopell commented Nov 19, 2022

v18.12.1

@ctjlewis
Copy link
Collaborator

Can you run upg update? I can't repro on latest.

@cpopell
Copy link
Author

cpopell commented Nov 19, 2022

I ran it ~3 minutes ago. Do you have a way to show upg ver?

@ctjlewis
Copy link
Collaborator

Ohhhhh, the command upg explain, rather than the Explain command in the loop. I see it now.

That's basically a tradeoff of a library we use for that pasteable editor view. The standard readlines library won't let us paste a string containing \n, it submits immediately. I'll have to rewrite the editor view library basically.

For now use upg load [file] > Explain. No warning.

@cpopell
Copy link
Author

cpopell commented Nov 19, 2022

Will try - btw, I'm not even getting to pasting code. Running upg explain -immediately- causes that problem.

@ctjlewis
Copy link
Collaborator

I know. It's the library that opens that nano-like editor up, it uses a raw Buffer() call which Node warns against now. I'll have to rewrite that entire thing from scratch to fix that.

@ctjlewis ctjlewis changed the title upg explain leads to DeprecationWarning on Windows upg explain leads to DeprecationWarning on Windows Nov 20, 2022
@cyborgmarina
Copy link
Contributor

Just checking: with recent updates, is it still a problem?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants