Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Standard] Node distribution v2 #494

Closed
3 tasks done
cah-hbaum opened this issue Mar 4, 2024 · 2 comments · Fixed by #524
Closed
3 tasks done

[Standard] Node distribution v2 #494

cah-hbaum opened this issue Mar 4, 2024 · 2 comments · Fixed by #524
Assignees
@cah-hbaum
Labels
Container Issues or pull requests relevant for Team 2: Container Infra and Tooling SCS is standardized SCS is standardized SCS-VP10 Related to tender lot SCS-VP10 standards Issues / ADR / pull requests relevant for standardization & certification

Comments

@cah-hbaum
Copy link
Contributor

cah-hbaum commented Mar 4, 2024 •
edited
Loading

While working on the tests for the node distribution standard scs-0214-v1, we found a few issues that need to be addressed.

The formulation of sentences isn't quite clear in all cases, leading to problematic or unclear requirements.

The biggest issue, however, is that the standard cannot be tested as is. The test that has been devised relies on certain node labels that are set in many instances, but they need not be, so we have to amend the standard to make them required. To be specific, these labels are:

  • topology.kubernetes.io/region,
  • topology.kubernetes.io/zone,
  • kubernetes.io/hostname a custom SCS label with the physical host-id

The last point is to be addressed in the reference implementation via SovereignCloudStack/issues#540.

Definition of Done:
@cah-hbaum cah-hbaum added Container Issues or pull requests relevant for Team 2: Container Infra and Tooling standards Issues / ADR / pull requests relevant for standardization & certification SCS is standardized SCS is standardized SCS-VP10 Related to tender lot SCS-VP10 labels Mar 4, 2024
@cah-hbaum cah-hbaum mentioned this issue Mar 4, 2024
Closed
65 tasks
@mbuechse mbuechse mentioned this issue Mar 5, 2024
Open
@martinmo martinmo mentioned this issue Mar 5, 2024
Closed
@martinmo
Copy link
Member

kubernetes.io/hostname won't be used in favor of a custom label, which is being discussed in SovereignCloudStack/issues#540.

@mbuechse mbuechse linked a pull request Mar 18, 2024 that will close this issue
Create v2 of node distribution standard (issues/#494) #524
Merged
@cah-hbaum cah-hbaum self-assigned this May 28, 2024
@martinmo martinmo mentioned this issue Jun 10, 2024
Open
29 tasks
cah-hbaum added a commit that referenced this issue Jun 17, 2024
@cah-hbaum @mbuechse
Create v2 of node distribution standard (issues/#494) (#524)
6c82357 
* Update node distribution standard (issues/#540)

Adds the new label topology.scs.openstack.org/host-id to the standard and extend the standard to require providers to set the labels on their managed k8s clusters.
Like discussed in the SIG Standardization and Certification Meeting, the standard is updated to v2 with the changes made to it and like it was discussed in the Standardization/Certification meeting, we will set this v2 to a Draft state for now.
Some small cosmetic updates fixing some problems mentioned by @martinmo.
Did some more textual updates requested by @mbuechse.

---------

Signed-off-by: Hannes Baum <[email protected]>
Co-authored-by: Matthias Büchse <[email protected]>
@cah-hbaum
Copy link
Contributor Author

Follow-up issue: #639

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cah-hbaum cah-hbaum

Labels
Container Issues or pull requests relevant for Team 2: Container Infra and Tooling SCS is standardized SCS is standardized SCS-VP10 Related to tender lot SCS-VP10 standards Issues / ADR / pull requests relevant for standardization & certification
Projects
Sovereign Cloud Stack
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Create v2 of node distribution standard (issues/#494) SovereignCloudStack/standards
2 participants
@martinmo @cah-hbaum