From 5b73b5b94590a6997b980044f06dae3af0d49711 Mon Sep 17 00:00:00 2001 From: Nathan Glenn Date: Fri, 14 Jul 2023 16:05:44 -0500 Subject: [PATCH] Remove bad -rpath argument from Tcl link command Without a path argument, the first object file is added to the rpath and not linked into the SO, leading to libtclsoarlib.so only containing symbols from Tcl/src/main.cpp, and none from Tcl/src/TclSoarLib.cpp. I'm unsure of why this setting was originally added and whether there used to be a real path argument. --- Tcl/SConscript | 5 ----- 1 file changed, 5 deletions(-) diff --git a/Tcl/SConscript b/Tcl/SConscript index e6898f8520..d6c76abd19 100644 --- a/Tcl/SConscript +++ b/Tcl/SConscript @@ -44,11 +44,6 @@ if sys.platform == 'darwin': elif sys.platform.startswith('linux'): clone.Append(LIBS = ['Soar']) - # Currently requires Tcl 8.6 b/c it supports multiple threads without manual compilation. The following line - # hard-codes the path of the current Tcl 8.6 path on this system into the executable (it's used as the first, - # but not only, search path for the Tcl library) - # TODO: is this still needed? - clone.Append(LINKFLAGS = ['-Wl,-rpath']) elif sys.platform == 'win32': # Windows DLLs need to get linked to dependencies, whereas Linux and Mac shared objects do not # (not sure if this is really needed for TclSoarLib)