Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR: Improve wording for Settings > Transitive > rounds #550

Open
charleshan opened this issue May 4, 2024 · 3 comments
Open

FR: Improve wording for Settings > Transitive > rounds #550

charleshan opened this issue May 4, 2024 · 3 comments
Labels
FR New feature or request implied relations Implied edges

Comments

@charleshan
Copy link

Is your feature request related to a problem? Please describe.
I just started using the latest version in beta and I noticed Settings > Transitive > rounds, which was cryptic without reading the docs.

Describe the solution you'd like
We should use a better choice of words and better UI. How about visibility with a dropdown for disabled, explicit only, and implicit and explicit. We wouldn't even have to change how we save the value (0, 1, or 2).

@charleshan charleshan added the FR New feature or request label May 4, 2024
@SkepticMystic
Copy link
Owner

@mProjectsCode I like this suggestion. We can keep the rounds as an implementation detail, but perhaps only give the choice of the 3 options above. Maybe if someone asks for it, there can be an "advanced" feature to set rounds explicitly

@SkepticMystic SkepticMystic added the implied relations Implied edges label May 4, 2024
@mProjectsCode
Copy link
Contributor

mProjectsCode commented May 4, 2024

implicit and explicit does not relate to 2 though, it relates to potentially very many, not sure about the exact bound but an upper bound should be node_count * rule_count, of rounds.

@SkepticMystic
Copy link
Owner

SkepticMystic commented May 5, 2024

I was thinking we could use some high-enough value for 2. Like currently, all implied rules are set to rounds: 10 by default. We can push it higher, but I think nodes * rules is practically too high

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FR New feature or request implied relations Implied edges
Projects
Status: Todo
Development

No branches or pull requests

3 participants