Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_Templated not converting #27

Open
mmaxwell opened this issue Apr 3, 2013 · 1 comment
Open

_Templated not converting #27

mmaxwell opened this issue Apr 3, 2013 · 1 comment
Labels

Comments

@mmaxwell
Copy link
Contributor

mmaxwell commented Apr 3, 2013

_Templated is not converted to dijit/_TemplatedMixin.

Also, when a widget has widgetsInTempalte: true, the dijit/_WidgetsInTemplateMixin mixin should be added.

@wkeese
Copy link

wkeese commented Apr 6, 2013

I see you are already converting templatePath to templateString (and loading the template via dojo/text!).

The other minor point is that technically waiRole and waiState in templates should be converted (as explained in http://dojotoolkit.org/reference-guide/1.8/releasenotes/migration-2.0.html#releasenotes-migration-2-0), but maybe that's not important enough to worry about. I doubt many people are using those attributes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants