Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add handler for dojo.exists #22

Open
mmaxwell opened this issue Apr 1, 2013 · 1 comment
Open

Add handler for dojo.exists #22

mmaxwell opened this issue Apr 1, 2013 · 1 comment
Labels

Comments

@mmaxwell
Copy link
Contributor

mmaxwell commented Apr 1, 2013

dojo.exists calls are not handled. In the trivial case, dojo.exists('foo', obj) can probably be converted to something like obj.foo != null (this might even be oversimplified given some of the magic used by dojo.exists). For more complex cases like dojo.exists('foo.bar', obj) or dojo.exists('global.foo') we probably need to just call lang.exists rather than unravel some of the magic.

@francesmcmullin
Copy link
Contributor

Even for that trivial case we probably shouldn't assume obj is defined. What's wrong with always switching dojo.exists to lang.exists?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants