New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VMG to course should be based on COG, not Heading? #33

Open

tkurki opened this issue Jun 18, 2019 · 1 comment

Labels

good first task

Member

tkurki commented Jun 18, 2019

signalk-derived-data/calcs/vmg.js

Line 9 in 9318f3d

'navigation.headingTrue',

Why heading? That's not where you are moving and way more inaccurate than COG.

tkurki changed the title ~~VMG to course should be based on COG; not Heading?~~ VMG to course should be based on COG, not Heading?

Contributor

chris0348 commented Mar 26, 2021

I had a look into vmg.js, I agree with Teppo that it is wrong to use headingTrue, instead, COG should be used.

chris0348 mentioned this issue

fix: VMG towards waypoint based on courseOverGround instead of headingTrue #80

Merged

tkurki added the good first task label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment