Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

$G command not reporting for grblHAL #537

Open
jgreilick opened this issue Aug 19, 2024 · 0 comments
Open

$G command not reporting for grblHAL #537

jgreilick opened this issue Aug 19, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@jgreilick
Copy link

I have found that when connecting to grblHAL firmware, $G from the console does not report the parser state. I have looked through the source code and believe I have found the issue. I have not built and tested, but this is what I found:

from - src/server/controllers/Grblhal/constants.js - Line 48

GCODE_REPORT: '$G\n', should be GCODE_REPORT: '$G', without the newline character. This newline character is inconsistent with similar constants defined here and with the corresponding equality check for $G that occurs in the GrblController (Line 2107).

@SienciLabs SienciLabs added the bug Something isn't working label Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants