Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in /tools/geometry_utils.py line 132 #37

Open
rpartzsch opened this issue Nov 3, 2023 · 4 comments
Open

Bug in /tools/geometry_utils.py line 132 #37

rpartzsch opened this issue Nov 3, 2023 · 4 comments
Labels
bug Something isn't working

Comments

@rpartzsch
Copy link

In /tools/geometry_utils.py in the function get_line_intersection_with_plane is a small bug in line 132. One can just remove the raise.

https://github.com/SiLab-Bonn/beam_telescope_analysis/blob/master/beam_telescope_analysis/tools/geometry_utils.py#L132C1-L132C14

@leloup314 leloup314 added the bug Something isn't working label Nov 3, 2023
@leloup314
Copy link
Member

Yes, looks like a bug to me as well! Maybe @YannickDieter can confirm?

@YannickDieter
Copy link
Collaborator

What do you mean with "One can just remove the raise."

To me the raise does not make much sense and we should remove it.

@leloup314
Copy link
Member

He means exactly what you said: The raise statement should be removed since there is no exception to re-raise which will result in an exception itself.

@YannickDieter
Copy link
Collaborator

Feel free to fix that in any branch you are working with at the moment :)
@rpartzsch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants