-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Icon]: Update icon Exit #12579
Comments
This biggest issue with the current proposal is it doesn't follow the basic guidelines of our icon library. It is much to big and breaks way outside the defined keylines. We could look at making it more square but would need to still follow our guidelines. We also would need a design that also works for the Enter icon as these two need to mirror eachother. |
For sure. I saw you added a few explorations in there (thank you! 🙌). I tried a few more as well. 3 & 4 are feeling decent to me, I'm curious what you think. |
The thing 4 misses for me is that feeling that the arrow is entering or leaving the box. 2 and 3 do that better imo. |
Yeah i'm fine with either so if you all have a preference we can go with that. |
Ok great, thank you! I chatted with @jasonsantamaria and we both feel good about 3. What are our next steps in that case? Here's the code for those: Enter
Exit
|
First we can get it updated in Figma. Then once the icon migration is done,
we can update the repo to get this into prod. That migration project is
just moving the the release phase so it shouldn't be very long before we
can make that happen.
|
Why are you proposing this update?
👋 I'd like to propose updating the Exit icon to have more of a squared-off shape. There's admittedly some subjectivity involved in this proposal, but a couple notes:
There's definitely room for refinement in the proposal, but I think it's a step in the right direction. The proposed icon is currently implemented as a custom icon in the Online Store Editor, and we'd like to bring things more in line with Polaris.
cc @vernalkick @jasonsantamaria @heyjoethomas
Icon name
Exit
Icon Figma link
https://www.figma.com/design/KXKb8CcuhfYjFWEiJFMHK7/Polaris-Exit-Icon?node-id=0-1
Icon SVG code
Are there any other important details?
No response
The text was updated successfully, but these errors were encountered: