Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Shopify CLI experiencing heavy throttling by Partners API #4335

Closed
2 tasks done
keiraarts opened this issue Aug 15, 2024 · 4 comments
Closed
2 tasks done

[Bug]: Shopify CLI experiencing heavy throttling by Partners API #4335

keiraarts opened this issue Aug 15, 2024 · 4 comments
Labels
Type: Bug Something isn't working

Comments

@keiraarts
Copy link

Please confirm that you have:

  • Searched existing issues to see if your issue is a duplicate. (If you’ve found a duplicate issue, feel free to add additional information in a comment on it.)
  • Reproduced the issue in the latest CLI version.

In which of these areas are you experiencing a problem?

App, Extension, Function, Theme, Other

Expected behavior

Deploying a preview of my Shopify app should upload all of my extension points and start the development server.

Actual behavior

Uploading more than (50) customer accounts checkout points (ex: Shopify Flow templates, customer accounts extensions, checkout ui extensions, post purchase extensions etc) is throttled by the Shopify CLI an I can't upload them.

ff9527f9401d9488e0d56639cbe9211a

Verbose output

thank-you-static │ thank-you-static
successfully built
  third-party-integration │ third-party-integration
successfully built
             thank-you-v2 │ thank-you-v2 successfully
built
 individual-order-summary │ individual-order-summary
successfully built
      order-status-static │ order-status-static
successfully built
     account-cancel-order │ account-cancel-order
successfully built
       customers-accounts │ customers-accounts
successfully built
     order-editing-badges │
 cart-transform-extension │ Bundling JS function...
  payment-methods-upsells │ Bundling JS function...
 cart-transform-extension │ Running javy...
  payment-methods-upsells │ Running javy...
 cart-transform-extension │ Done!
  payment-methods-upsells │ Done!

╭─ success ────────────────────────────────────────────╮
│                                                      │
│  extensions built!                                   │
│

Reproduction steps

  1. Create 100 extension points that have a Typescript build step.
  2. yarn Shopify dev
  3. Shopify builds them and fails on the last 10% because it's throttled by the Partners APi.

Operating System

Mac OS Monetery

Shopify CLI version (check your project's package.json if you're not sure)

3.65.3

Shell

No response

Node version (run node -v if you're not sure)

v18

What language and version are you using in your application?

Node, Typescript

@keiraarts keiraarts added the Type: Bug Something isn't working label Aug 15, 2024
@amcaplan
Copy link
Contributor

Hi @keiraarts, this is related to an ongoing investigation. We will be posting updates to #4318.

Closing in favor of the existing issue, please follow the thread there.

@amcaplan
Copy link
Contributor

Ah, wait, now I see this was a 429. Looks like we're throttling extension draft updates server-side, but not throttling effectively on the CLI side. So this is a CLI issue, not an API issue.

Reopening.

@amcaplan amcaplan reopened this Aug 19, 2024
@amcaplan
Copy link
Contributor

This should be fixed by #4260 but we'll keep the issue open until we've confirmed.

By the way, you can try out the fix already by using the nightly CLI.

Globally: npm install -g @shopify/cli@nightly
Locally in your app's package.json: change the version reference of @shopify/cli to nightly and use your package manager to reinstall dependencies

@isaacroldan
Copy link
Contributor

Closing as this was fixed in the last version, if the issue persist please comment or open a new issue. thanks for reporting!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants