Issue #27 capitalize the brand variable for the Xiaomi brand #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This pull request resolves Issue #27 by ensuring the correct capitalization of the brand variable for Xiaomi devices. Previously, the $BRAND variable incorrectly held the value "xiaomi" instead of the standard "Xiaomi". By adding a line in
rom_vars.sh, this issue is rectified, aligning with the expected brand representation.Changes Made:
rom_vars.shto capitalize the brand variable for Xiaomi devices.Purpose:
The primary purpose of this pull request is to fix the capitalization inconsistency in the brand variable for Xiaomi devices. By ensuring that the $BRAND variable holds the correct capitalization, this enhancement improves code clarity and maintains consistency across the codebase, contributing to a better user experience.
How to Test:
Related Issues:
Additional Notes:
This pull request adheres to the project's coding standards and has been tested to ensure proper functionality. Feedback and suggestions for further improvement are welcome.